Add Basic examples that can be included in README#64
Merged
sharpener6 merged 21 commits intofinos:mainfrom Apr 1, 2025
Merged
Conversation
All examples will be in this directory later Signed-off-by: gxu <georgexu420@gmail.com>
Read readme for more information Signed-off-by: gxu <georgexu420@gmail.com>
This make sure all examples are checked when tests are triggered Signed-off-by: gxu <georgexu420@gmail.com>
Signed-off-by: gxu <georgexu420@gmail.com>
Signed-off-by: gxu <georgexu420@gmail.com>
Signed-off-by: gxu <georgexu420@gmail.com>
Signed-off-by: gxu <georgexu420@gmail.com>
Signed-off-by: gxu <georgexu420@gmail.com>
Signed-off-by: gxu <georgexu420@gmail.com>
rafa-be
requested changes
Mar 28, 2025
Collaborator
rafa-be
left a comment
There was a problem hiding this comment.
A few changes I'd suggest:
- Could we merge some of these examples?
simple_client,send_object,disconnect_clientandmap_clientshare 90% of the code, maybe you can merge them as a single file with basic use cases on how to use the Scaler's client.graphtask_nested_clientcan be a little bit simplified, and possibly added tographtask_client, to demonstrate that you can submit graph tasks from within a task.simple_schedulerandsimple_clustercould be merged in a single example showing the different ways of setting a Scaler cluster.
- What is the text wrapping setting for comments? I've the feeling that these are not consistent.
- Maybe use a docstring when describing the file's content, like I did here: https://github.com/rafa-be/parfun/blob/main/benchmarks/california_housing.py
added 3 commits
March 28, 2025 23:09
Signed-off-by: gxu <georgexu420@gmail.com>
Use docstring and line wrap comment with 120 col. Signed-off-by: gxu <georgexu420@gmail.com>
Signed-off-by: gxu <georgexu420@gmail.com>
Co-authored-by: magniloquency <197707854+magniloquency@users.noreply.github.com> Signed-off-by: gxu <69813939+gxuu@users.noreply.github.com>
Signed-off-by: gxu <georgexu420@gmail.com>
Signed-off-by: gxu <georgexu420@gmail.com>
Co-authored-by: magniloquency <197707854+magniloquency@users.noreply.github.com> Signed-off-by: gxu <69813939+gxuu@users.noreply.github.com>
Co-authored-by: magniloquency <197707854+magniloquency@users.noreply.github.com> Signed-off-by: gxu <69813939+gxuu@users.noreply.github.com>
Signed-off-by: gxu <georgexu420@gmail.com>
sharpener6
previously approved these changes
Mar 31, 2025
Collaborator
|
@gxuu , please fix linter issue, always run the same linter git flow script |
Signed-off-by: gxu <georgexu420@gmail.com>
Collaborator
I understand the refactoring purpose, but my thinking about this is slightly different, since this is for example, the goal for those should be executable and able to copy for each example, so it's better to be in one snippet |
sharpener6
approved these changes
Mar 31, 2025
sharpener6
approved these changes
Mar 31, 2025
rafa-be
approved these changes
Apr 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR working on adding more examples of using scaler